fix: add gap between labels and values in all properties panes
Add gap-3 to PropertyRow flex containers so labels don't touch their values. Also add shrink-0 on labels and min-w-0 on value containers to prevent overflow issues. Applied to: IssueProperties, AgentProperties, GoalProperties, ProjectProperties. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -23,9 +23,9 @@ const adapterLabels: Record<string, string> = {
|
|||||||
|
|
||||||
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center justify-between py-1.5">
|
<div className="flex items-center justify-between gap-3 py-1.5">
|
||||||
<span className="text-xs text-muted-foreground">{label}</span>
|
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
|
||||||
<div className="flex items-center gap-1.5">{children}</div>
|
<div className="flex items-center gap-1.5 min-w-0">{children}</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -21,9 +21,9 @@ interface GoalPropertiesProps {
|
|||||||
|
|
||||||
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center justify-between py-1.5">
|
<div className="flex items-center justify-between gap-3 py-1.5">
|
||||||
<span className="text-xs text-muted-foreground">{label}</span>
|
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
|
||||||
<div className="flex items-center gap-1.5">{children}</div>
|
<div className="flex items-center gap-1.5 min-w-0">{children}</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -22,9 +22,9 @@ interface IssuePropertiesProps {
|
|||||||
|
|
||||||
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center justify-between py-1.5">
|
<div className="flex items-center justify-between gap-3 py-1.5">
|
||||||
<span className="text-xs text-muted-foreground">{label}</span>
|
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
|
||||||
<div className="flex items-center gap-1.5">{children}</div>
|
<div className="flex items-center gap-1.5 min-w-0">{children}</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,7 +1,16 @@
|
|||||||
|
import { useState } from "react";
|
||||||
|
import { Link } from "react-router-dom";
|
||||||
|
import { useQuery } from "@tanstack/react-query";
|
||||||
import type { Project } from "@paperclip/shared";
|
import type { Project } from "@paperclip/shared";
|
||||||
import { StatusBadge } from "./StatusBadge";
|
import { StatusBadge } from "./StatusBadge";
|
||||||
import { formatDate } from "../lib/utils";
|
import { formatDate } from "../lib/utils";
|
||||||
|
import { goalsApi } from "../api/goals";
|
||||||
|
import { useCompany } from "../context/CompanyContext";
|
||||||
|
import { queryKeys } from "../lib/queryKeys";
|
||||||
import { Separator } from "@/components/ui/separator";
|
import { Separator } from "@/components/ui/separator";
|
||||||
|
import { Button } from "@/components/ui/button";
|
||||||
|
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
|
||||||
|
import { Plus, X } from "lucide-react";
|
||||||
|
|
||||||
interface ProjectPropertiesProps {
|
interface ProjectPropertiesProps {
|
||||||
project: Project;
|
project: Project;
|
||||||
@@ -10,14 +19,49 @@ interface ProjectPropertiesProps {
|
|||||||
|
|
||||||
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
function PropertyRow({ label, children }: { label: string; children: React.ReactNode }) {
|
||||||
return (
|
return (
|
||||||
<div className="flex items-center justify-between py-1.5">
|
<div className="flex items-center justify-between gap-3 py-1.5">
|
||||||
<span className="text-xs text-muted-foreground">{label}</span>
|
<span className="text-xs text-muted-foreground shrink-0">{label}</span>
|
||||||
<div className="flex items-center gap-1.5">{children}</div>
|
<div className="flex items-center gap-1.5 min-w-0">{children}</div>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
export function ProjectProperties({ project, onUpdate }: ProjectPropertiesProps) {
|
export function ProjectProperties({ project, onUpdate }: ProjectPropertiesProps) {
|
||||||
|
const { selectedCompanyId } = useCompany();
|
||||||
|
const [goalOpen, setGoalOpen] = useState(false);
|
||||||
|
|
||||||
|
const { data: allGoals } = useQuery({
|
||||||
|
queryKey: queryKeys.goals.list(selectedCompanyId!),
|
||||||
|
queryFn: () => goalsApi.list(selectedCompanyId!),
|
||||||
|
enabled: !!selectedCompanyId,
|
||||||
|
});
|
||||||
|
|
||||||
|
const linkedGoalIds = project.goalIds.length > 0
|
||||||
|
? project.goalIds
|
||||||
|
: project.goalId
|
||||||
|
? [project.goalId]
|
||||||
|
: [];
|
||||||
|
|
||||||
|
const linkedGoals = project.goals.length > 0
|
||||||
|
? project.goals
|
||||||
|
: linkedGoalIds.map((id) => ({
|
||||||
|
id,
|
||||||
|
title: allGoals?.find((g) => g.id === id)?.title ?? id.slice(0, 8),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const availableGoals = (allGoals ?? []).filter((g) => !linkedGoalIds.includes(g.id));
|
||||||
|
|
||||||
|
const removeGoal = (goalId: string) => {
|
||||||
|
if (!onUpdate) return;
|
||||||
|
onUpdate({ goalIds: linkedGoalIds.filter((id) => id !== goalId) });
|
||||||
|
};
|
||||||
|
|
||||||
|
const addGoal = (goalId: string) => {
|
||||||
|
if (!onUpdate || linkedGoalIds.includes(goalId)) return;
|
||||||
|
onUpdate({ goalIds: [...linkedGoalIds, goalId] });
|
||||||
|
setGoalOpen(false);
|
||||||
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="space-y-4">
|
<div className="space-y-4">
|
||||||
<div className="space-y-1">
|
<div className="space-y-1">
|
||||||
@@ -29,11 +73,71 @@ export function ProjectProperties({ project, onUpdate }: ProjectPropertiesProps)
|
|||||||
<span className="text-sm font-mono">{project.leadAgentId.slice(0, 8)}</span>
|
<span className="text-sm font-mono">{project.leadAgentId.slice(0, 8)}</span>
|
||||||
</PropertyRow>
|
</PropertyRow>
|
||||||
)}
|
)}
|
||||||
{project.goalId && (
|
<div className="py-1.5">
|
||||||
<PropertyRow label="Goal">
|
<div className="flex items-start justify-between gap-2">
|
||||||
<span className="text-sm font-mono">{project.goalId.slice(0, 8)}</span>
|
<span className="text-xs text-muted-foreground">Goals</span>
|
||||||
</PropertyRow>
|
<div className="flex flex-col items-end gap-1.5">
|
||||||
|
{linkedGoals.length === 0 ? (
|
||||||
|
<span className="text-sm text-muted-foreground">None</span>
|
||||||
|
) : (
|
||||||
|
<div className="flex flex-wrap justify-end gap-1.5 max-w-[220px]">
|
||||||
|
{linkedGoals.map((goal) => (
|
||||||
|
<span
|
||||||
|
key={goal.id}
|
||||||
|
className="inline-flex items-center gap-1 rounded-md border border-border px-2 py-1 text-xs"
|
||||||
|
>
|
||||||
|
<Link to={`/goals/${goal.id}`} className="hover:underline max-w-[140px] truncate">
|
||||||
|
{goal.title}
|
||||||
|
</Link>
|
||||||
|
{onUpdate && (
|
||||||
|
<button
|
||||||
|
className="text-muted-foreground hover:text-foreground"
|
||||||
|
type="button"
|
||||||
|
onClick={() => removeGoal(goal.id)}
|
||||||
|
aria-label={`Remove goal ${goal.title}`}
|
||||||
|
>
|
||||||
|
<X className="h-3 w-3" />
|
||||||
|
</button>
|
||||||
)}
|
)}
|
||||||
|
</span>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
{onUpdate && (
|
||||||
|
<Popover open={goalOpen} onOpenChange={setGoalOpen}>
|
||||||
|
<PopoverTrigger asChild>
|
||||||
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
size="xs"
|
||||||
|
className="h-6 px-2"
|
||||||
|
disabled={availableGoals.length === 0}
|
||||||
|
>
|
||||||
|
<Plus className="h-3 w-3 mr-1" />
|
||||||
|
Goal
|
||||||
|
</Button>
|
||||||
|
</PopoverTrigger>
|
||||||
|
<PopoverContent className="w-56 p-1" align="end">
|
||||||
|
{availableGoals.length === 0 ? (
|
||||||
|
<div className="px-2 py-1.5 text-xs text-muted-foreground">
|
||||||
|
All goals linked.
|
||||||
|
</div>
|
||||||
|
) : (
|
||||||
|
availableGoals.map((goal) => (
|
||||||
|
<button
|
||||||
|
key={goal.id}
|
||||||
|
className="flex items-center w-full px-2 py-1.5 text-xs rounded hover:bg-accent/50"
|
||||||
|
onClick={() => addGoal(goal.id)}
|
||||||
|
>
|
||||||
|
{goal.title}
|
||||||
|
</button>
|
||||||
|
))
|
||||||
|
)}
|
||||||
|
</PopoverContent>
|
||||||
|
</Popover>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
{project.targetDate && (
|
{project.targetDate && (
|
||||||
<PropertyRow label="Target Date">
|
<PropertyRow label="Target Date">
|
||||||
<span className="text-sm">{formatDate(project.targetDate)}</span>
|
<span className="text-sm">{formatDate(project.targetDate)}</span>
|
||||||
|
|||||||
Reference in New Issue
Block a user