Merge pull request #628 from STRML/fix/remove-cmd-number-shortcut
fix: remove Cmd+1..9 company-switch shortcut
This commit is contained in:
@@ -104,23 +104,12 @@ export function Layout() {
|
|||||||
|
|
||||||
const togglePanel = togglePanelVisible;
|
const togglePanel = togglePanelVisible;
|
||||||
|
|
||||||
// Cmd+1..9 to switch companies
|
|
||||||
const switchCompany = useCallback(
|
|
||||||
(index: number) => {
|
|
||||||
if (index < companies.length) {
|
|
||||||
setSelectedCompanyId(companies[index]!.id);
|
|
||||||
}
|
|
||||||
},
|
|
||||||
[companies, setSelectedCompanyId],
|
|
||||||
);
|
|
||||||
|
|
||||||
useCompanyPageMemory();
|
useCompanyPageMemory();
|
||||||
|
|
||||||
useKeyboardShortcuts({
|
useKeyboardShortcuts({
|
||||||
onNewIssue: () => openNewIssue(),
|
onNewIssue: () => openNewIssue(),
|
||||||
onToggleSidebar: toggleSidebar,
|
onToggleSidebar: toggleSidebar,
|
||||||
onTogglePanel: togglePanel,
|
onTogglePanel: togglePanel,
|
||||||
onSwitchCompany: switchCompany,
|
|
||||||
});
|
});
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
|
|||||||
@@ -4,10 +4,9 @@ interface ShortcutHandlers {
|
|||||||
onNewIssue?: () => void;
|
onNewIssue?: () => void;
|
||||||
onToggleSidebar?: () => void;
|
onToggleSidebar?: () => void;
|
||||||
onTogglePanel?: () => void;
|
onTogglePanel?: () => void;
|
||||||
onSwitchCompany?: (index: number) => void;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export function useKeyboardShortcuts({ onNewIssue, onToggleSidebar, onTogglePanel, onSwitchCompany }: ShortcutHandlers) {
|
export function useKeyboardShortcuts({ onNewIssue, onToggleSidebar, onTogglePanel }: ShortcutHandlers) {
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
function handleKeyDown(e: KeyboardEvent) {
|
function handleKeyDown(e: KeyboardEvent) {
|
||||||
// Don't fire shortcuts when typing in inputs
|
// Don't fire shortcuts when typing in inputs
|
||||||
@@ -16,13 +15,6 @@ export function useKeyboardShortcuts({ onNewIssue, onToggleSidebar, onTogglePane
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Cmd+1..9 → Switch company
|
|
||||||
if ((e.metaKey || e.ctrlKey) && e.key >= "1" && e.key <= "9") {
|
|
||||||
e.preventDefault();
|
|
||||||
onSwitchCompany?.(parseInt(e.key, 10) - 1);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// C → New Issue
|
// C → New Issue
|
||||||
if (e.key === "c" && !e.metaKey && !e.ctrlKey && !e.altKey) {
|
if (e.key === "c" && !e.metaKey && !e.ctrlKey && !e.altKey) {
|
||||||
e.preventDefault();
|
e.preventDefault();
|
||||||
@@ -44,5 +36,5 @@ export function useKeyboardShortcuts({ onNewIssue, onToggleSidebar, onTogglePane
|
|||||||
|
|
||||||
document.addEventListener("keydown", handleKeyDown);
|
document.addEventListener("keydown", handleKeyDown);
|
||||||
return () => document.removeEventListener("keydown", handleKeyDown);
|
return () => document.removeEventListener("keydown", handleKeyDown);
|
||||||
}, [onNewIssue, onToggleSidebar, onTogglePanel, onSwitchCompany]);
|
}, [onNewIssue, onToggleSidebar, onTogglePanel]);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1313,7 +1313,7 @@ export function DesignGuide() {
|
|||||||
["C", "New Issue (outside inputs)"],
|
["C", "New Issue (outside inputs)"],
|
||||||
["[", "Toggle Sidebar"],
|
["[", "Toggle Sidebar"],
|
||||||
["]", "Toggle Properties Panel"],
|
["]", "Toggle Properties Panel"],
|
||||||
["Cmd+1..9 / Ctrl+1..9", "Switch Company (by rail order)"],
|
|
||||||
["Cmd+Enter / Ctrl+Enter", "Submit markdown comment"],
|
["Cmd+Enter / Ctrl+Enter", "Submit markdown comment"],
|
||||||
].map(([key, desc]) => (
|
].map(([key, desc]) => (
|
||||||
<div key={key} className="flex items-center justify-between px-4 py-2">
|
<div key={key} className="flex items-center justify-between px-4 py-2">
|
||||||
|
|||||||
Reference in New Issue
Block a user